Commit Graph

1195 Commits

Author SHA1 Message Date
Nicholas Nethercote
dbcea71779 More docs build tweaks:
- Actually remove the dead docs/images/massif*.png files (this was meant to
  happen in r10720).

- Inline $TOOL/docs/Makefile.am into $TOOL/Makefile.am for all 10 tools.  10
  fewer Makefile.am files FTW!


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10721
2009-08-05 08:08:18 +00:00
Nicholas Nethercote
439594978f Various fix-ups for Memcheck's manual chapter.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10716
2009-08-05 06:34:27 +00:00
Nicholas Nethercote
8da3d6fbc0 Move command-line option details after the description of Memcheck's error
messages, since that's an order that will make more sense for a newbie.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10715
2009-08-05 05:11:02 +00:00
Nicholas Nethercote
36e289ca64 Augment a comment.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10714
2009-08-05 05:05:15 +00:00
Nicholas Nethercote
ec073bad3d Added documentation for --ignore-ranges. It's not very good, though, if
anyone can explain clearly why it's useful and wants to add that information
that would be helpful.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10713
2009-08-05 04:57:44 +00:00
Nicholas Nethercote
e06d3b4893 Put Memcheck's command line options in the manual in the same order as its
usage message.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10712
2009-08-05 04:54:51 +00:00
Nicholas Nethercote
daa35cac73 Various clean-ups, mostly in chapter 3.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10705
2009-08-04 05:24:46 +00:00
Nicholas Nethercote
8026c4766f Various option-related tweaks:
- Match the ordering of the non-tool-specific options in the usage message
  with the order in the user manual.  As a result, we now always print
  --alignment and --trace-malloc in the core's usage messages, which saves
  malloc-replacing tools from doing it themselves (and brings it in line
  with options that only apply to error-collecting tools).

- Improved the presentation of the Vex options with --help-debug.

- Removed documentation of -d in the manual because it's a debugging-only flag.

- Documented --read-var-info in the manual.  This fixes bug 201169.

- Renamed --auto-run-dsymutil as --dsymutil and documented it in the usage
  message.

- Fixed an XML error in manual-core-adv.xml.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10703
2009-08-04 02:32:55 +00:00
Nicholas Nethercote
d5b384f852 Various manual fix-ups:
- Use "heap blocks" rather than "malloc'd blocks" as heap blocks covers
  calloc, realloc, new, new[], memalign, etc.

- Used "GDB" and "GCC" throughout rather than "gcc" and "gdb".

- Made various tag uses more consistent.

- Greatly clarified the instructions on --xml=yes and its friends.

- Lots of other little improvements and fixes to out-of-date things and
  Linux-centric things, mostly in Section 2.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10701
2009-08-04 01:16:01 +00:00
Nicholas Nethercote
9c4252c6a1 Don't wrap the "Command:" line, as doing so makes cutting-and-pasting the
command difficult.  Also, when wrapping I was failing to factor in the
escape chars needed for chars like ' ';  now I don't need to.  And this
means the 'long-command' test is no longer necessary.  In other words,
favour utility and simplicity over aesthetics.

Also, the "Command:" line wasn't being wrapped in <line></line> in XML
output.  It now is.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10699
2009-08-04 00:27:56 +00:00
Nicholas Nethercote
5dfe01a847 With the recent VG_(message) change,
VALGRIND_{PRINTF,PRINTF_BACKTRACE,INTERNAL_PRINTF} were no longer appending
newlines.  This meant that --trace-malloc=yes spewed everything onto a
single line, among other things.

Rather than adding the newline back in, I chose to offically change their
behaviour to not add the newlines, as this is more flexible (and the reason
for the underlying VG_(message) change).  I updated all the relevant places
I could find.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10694
2009-08-03 01:38:56 +00:00
Julian Seward
d7ed7f6a13 (almost completely just function renaming):
* VG_(find_seginfo): incrementally rearrange the DebugInfo list, like
  most of the other list-searching functions do.

* rename all VG_(*seginfo*) functions exported from m_debuginfo to
  VG_(*DebugInfo*).  "seginfo" was a historical name which was mostly
  but not completely, done away with some time back.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10678
2009-07-31 09:41:29 +00:00
Nicholas Nethercote
ac7761261a We currently use a mix of <option> and <computeroutput> tags for command
line options.  This commit changes them to all <option>.

Also make consistent how options with multiple names (eg. -h --help) are
shown.

Also, remove section describing --help and --version in Callgrind's chapter;
these aren't necessary and are presumably a hangover from when Callgrind was
a separate tool.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10659
2009-07-30 02:57:52 +00:00
Nicholas Nethercote
78b2e5c83e Started overhauling the documentation:
- There were detailed descriptions of all the tools in the Quick Start
  Guide, the Manual introduction, and the start of each tool chapter.  To
  avoid duplication/overlap, I removed these altogether from the Quick Start
  Guide, and shortened them in the intro.

- Improved the description of what errors Memcheck can find.

- Made all tool chapters start with "Overview" section, for consistency.

- Made the "run with --tool=XXX" bit consistent in each tool chapter.

- Made all tool chapter titles match the description given when running them.

- Added BBV to the User Manual intro.

- Generally clarified, updated, and future-proofed various bits of text in
  the Quick Start Guide and User Manual introduction. 

Also:
- Changed Nulgrind's start-up description to "the minimal Valgrind tool".

- Fixed some punctuation in the usage message.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10652
2009-07-29 02:36:21 +00:00
Bart Van Assche
0ebd83edda Un-break regression test run.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10648
2009-07-28 08:03:31 +00:00
Nicholas Nethercote
ff3b502612 Remove non-Linux code from this Linux-only test.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10646
2009-07-28 05:11:42 +00:00
Nicholas Nethercote
1165808df3 Make lsframe1, lsframe2 and stack_changes Linux-only since they all fault
natively on Mac.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10645
2009-07-28 05:10:33 +00:00
Bart Van Assche
2919d92191 Fixed a bug in the code for reading suppression files: the line numbers
reported in error messages were not correct. As an example, the following
output was produced before this patch (not correct):
$ ./vg-in-place --tool=helgrind --num-callers=1 /bin/true
...
FATAL: in suppressions file ".in_place/default.supp" near line 893:
   suppression must contain at least one location line which is not "..."
exiting now.
$ ./vg-in-place --tool=drd --num-callers=1 /bin/true
FATAL: in suppressions file ".in_place/default.supp" near line 475:
   suppression must contain at least one location line which is not "..."
exiting now.

After having applied this patch the above commands display line numbers
1104 and 619, referring to the first suppression pattern containing
three dots for the topmost stack frame, as expected.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10632
2009-07-27 12:03:03 +00:00
Bart Van Assche
6ccb6fd429 Remove the temporary file created during the test before exiting.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10614
2009-07-26 15:43:39 +00:00
Nicholas Nethercote
024171ae89 Uncomment this; not sure why it was commented out.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10597
2009-07-24 20:48:36 +00:00
Nicholas Nethercote
6745c903fc Add a note about our suspect handling of brk(). And disable the brk() part
of origin1-yes.c, because it's a pain, giving different results on different
systems.  This allowed origin1-yes.stderr.exp-darwin to be removed.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10595
2009-07-24 19:09:52 +00:00
Nicholas Nethercote
68efb29503 A fix for bug 186796: suppression symbol names were being truncated if they
were longer than 200 chars.  Now dynamic memory is used and so they can be
arbitrarily long in theory, although in practice it bombs out at 100,000 for
sanity purposes.  This required adjusting the core/tool interface for
read_extra_suppression_info().  


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10581
2009-07-24 07:38:29 +00:00
Nicholas Nethercote
e3f6e42966 Fixed bug 149878 (calloc overflow). This disables some of the calloc silly
arg checking, but that's no great loss.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10578
2009-07-24 06:41:02 +00:00
Nicholas Nethercote
9cecb57a28 Handle the memory written by aio_read() properly -- mark the memory buffer
as written once aio_return() is successfully called.

Also check the addressability of the buffer for both aio_read() and
aio_write().

Also check the file descriptor for aio_read() and aio_write().

And add a test for this.  There's one corner case of the test that doesn't
work as expected and is currently commented out.  But aio_*() certainly
works better than it used to.

All this is for bug 197227.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10539
2009-07-23 04:30:06 +00:00
Nicholas Nethercote
ea965ab59c This should have gone in with r10537.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10538
2009-07-23 00:55:46 +00:00
Nicholas Nethercote
eefed9ebfc Add support for __pthread_kill(). This hopefully fixes bug 201016.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10537
2009-07-23 00:06:16 +00:00
Nicholas Nethercote
7b5d892035 Fix up xml1 on 32-bit machines; merged the 32 and 64-bit outputs by
extending the filter.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10494
2009-07-21 04:51:55 +00:00
Nicholas Nethercote
61a9677f7b Improve handling of clone() on x86/Linux. Based on a patch from Jeroen
Witmond.  This fixes bug 117564.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10493
2009-07-20 05:48:44 +00:00
Bart Van Assche
b83aa02475 Fixed XML syntax.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10487
2009-07-19 09:19:58 +00:00
Julian Seward
4f730a3c8e Merge memcheck/ changes from branches/MESSAGING_TIDYUP r10464.
See trunk r10465 commit message for details.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10467
2009-07-15 14:49:40 +00:00
Nicholas Nethercote
3758ff85e8 Add details about an interior-pointer case that can occur with C++.
Addresses bug 136230.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10462
2009-07-15 07:18:16 +00:00
Nicholas Nethercote
9ca3448218 Add support on Darwin for mount(). Finishes off bug 198624.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10461
2009-07-15 06:39:15 +00:00
Nicholas Nethercote
c5310baaff Added support for getfsstat64() on Darwin. This partly fixes bug 198624.
Fixed a couple of other minor things too.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10460
2009-07-15 06:24:57 +00:00
Nicholas Nethercote
ef7925e7bc Add support on Darwin for fstat_extended() and fstat64_extended(). Partly
addresses bug 198624.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10458
2009-07-15 06:01:45 +00:00
Nicholas Nethercote
705bcf4d73 Handle setpgid(). Partly addresses bug 198624.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10457
2009-07-15 05:46:43 +00:00
Nicholas Nethercote
2a7a73345f Ignore MALLOCLIKE_BLOCK/FREELIKE_BLOCK if addr==0. Fixes bug 137073. DRD
now has its own copy of custom_alloc.c which is a little different to
Memcheck's;  making them both work with the same version was too difficult.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10455
2009-07-15 02:31:45 +00:00
Nicholas Nethercote
75b92a2ec9 Shorten the preamble by moving some of it into the --help output. This
partly fixes bug 197933.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10451
2009-07-14 06:55:05 +00:00
Nicholas Nethercote
5715955132 Fix a couple of tests that could be built with the wrong options, including
the -m32/-m64 option.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10440
2009-07-13 22:20:00 +00:00
Nicholas Nethercote
6141840b2d Make atomic_incs.c build on Mac.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10435
2009-07-12 22:58:26 +00:00
Julian Seward
d8898802fc Track vex r1907 (introduce Iop_CmpCas{EQ,NE}{8,16,32,64} and use them
for CAS-success? tests).

Detailed background and rationale in memcheck/mc_translate, comment
"COMMENT_ON_CasCmpEQ".

This commit changes the Memcheck instrumentation of IRCAS so as not to
do a definedness check on the success/failure indication.  Also, by
being able to identify via the Iop_CasCmpEQ primitives any such checks
independently created by front ends, it can avoid instrumenting these
too.

All this is to avoid reporting new false positives observed on Fedora 7
(x86?) and openSUSE 10.2 (x86) following the recent merge of branches/DCAS.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10432
2009-07-12 13:00:17 +00:00
Nicholas Nethercote
400b917577 Handle epoll_create1. Patch from Sam Varshavchik. Fixes bug 188427.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10427
2009-07-10 12:02:03 +00:00
Nicholas Nethercote
7e075c243f Make --leak-resolution=high the default. Fixes bug 197929.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10423
2009-07-10 08:16:29 +00:00
Nicholas Nethercote
737f3050ca This file was accidentally empty; fill it with the right output.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10419
2009-07-09 22:52:24 +00:00
Julian Seward
62215c01ac Make this test work on PowerPC too.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10412
2009-07-04 14:33:53 +00:00
Bart Van Assche
5e4cf07ba5 Un-break PPC build.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10411
2009-07-04 14:20:43 +00:00
Julian Seward
205f7fa457 Add tests to verify behaviour of atomic instruction handling.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10410
2009-07-04 12:44:08 +00:00
Julian Seward
3109865279 Merge in branches/DCAS.
This branch adds proper support for atomic instructions, proper in the
sense that the atomicity is preserved through the compilation
pipeline, and thus in the instrumented code.

These changes track the IR changes added by vex r1901.  They primarily
update the instrumentation functions in all tools to handle the
changes, with the exception of exp-ptrcheck, which needs some further
work in order to be able to run threaded code.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10392
2009-07-01 08:10:49 +00:00
Bart Van Assche
06eb5d4a25 Applied the patch attached to http://bugs.kde.org/show_bug.cgi?id=165468: fixed some formatting inconsistencies.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10381
2009-06-26 19:03:53 +00:00
Nicholas Nethercote
363533b51b Suppress a leak in setenv(). Fixes bug 188572.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10380
2009-06-26 07:00:00 +00:00
Nicholas Nethercote
5e7562af08 Add support for various aio_*() syscalls on Darwin. With them, Quicktime
runs, albeit incredibly slowly.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10371
2009-06-24 06:25:36 +00:00