466 Commits

Author SHA1 Message Date
Nicholas Nethercote
86be4a7cf3 Update .exp files for r10783.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10784
2009-08-12 00:14:44 +00:00
Julian Seward
8ffe2fdefa Tidy up of messaging:
* For all tools and the core, don't show statistics when -v is in
  effect.  Instead, try to restrict -v to mostly user-useful
  stuff.

* A new flag --stats=no|yes [no] produces statistics output instead.

* Fix longstanding problem in that Memcheck's leak checker ran after
  the core's error manager module shut down, thereby not showing use
  counts of leak suppressions.  This fixes #186790.

* As a consequence, the leak checker text output of Memcheck has
  changed a bit -- leak check is done before the final error
  summary is done (much more logical), and the output has been
  tidied up a bit.

* Helgrind, Drd and Ptrcheck now also print "For counts of
  detected and suppressed errors, rerun with: -v", which makes
  them consistent with Memcheck in this regard.  These are
  filtered out by the regtest filter scripts.

For all tools except Memcheck, the regtests are unchanged.  On
Memcheck regtests still fail due to rearrangements of the leak
checker output.  This will be fixed by a followup commit.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10746
2009-08-07 15:46:56 +00:00
Nicholas Nethercote
8026c4766f Various option-related tweaks:
- Match the ordering of the non-tool-specific options in the usage message
  with the order in the user manual.  As a result, we now always print
  --alignment and --trace-malloc in the core's usage messages, which saves
  malloc-replacing tools from doing it themselves (and brings it in line
  with options that only apply to error-collecting tools).

- Improved the presentation of the Vex options with --help-debug.

- Removed documentation of -d in the manual because it's a debugging-only flag.

- Documented --read-var-info in the manual.  This fixes bug 201169.

- Renamed --auto-run-dsymutil as --dsymutil and documented it in the usage
  message.

- Fixed an XML error in manual-core-adv.xml.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10703
2009-08-04 02:32:55 +00:00
Nicholas Nethercote
0c1733b18a This should have been removed in r10699.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10700
2009-08-04 01:08:56 +00:00
Nicholas Nethercote
9c4252c6a1 Don't wrap the "Command:" line, as doing so makes cutting-and-pasting the
command difficult.  Also, when wrapping I was failing to factor in the
escape chars needed for chars like ' ';  now I don't need to.  And this
means the 'long-command' test is no longer necessary.  In other words,
favour utility and simplicity over aesthetics.

Also, the "Command:" line wasn't being wrapped in <line></line> in XML
output.  It now is.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10699
2009-08-04 00:27:56 +00:00
Nicholas Nethercote
5dfe01a847 With the recent VG_(message) change,
VALGRIND_{PRINTF,PRINTF_BACKTRACE,INTERNAL_PRINTF} were no longer appending
newlines.  This meant that --trace-malloc=yes spewed everything onto a
single line, among other things.

Rather than adding the newline back in, I chose to offically change their
behaviour to not add the newlines, as this is more flexible (and the reason
for the underlying VG_(message) change).  I updated all the relevant places
I could find.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10694
2009-08-03 01:38:56 +00:00
Nicholas Nethercote
635d2ba794 Forgot to add these in r10690.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10691
2009-08-03 00:23:16 +00:00
Nicholas Nethercote
c20ba72234 In the "Command:" line in the preamble, escape special chars such as ' ' and
'\\'.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10690
2009-08-02 23:03:06 +00:00
Nicholas Nethercote
a3fe17b34b Print the command being run at startup. It wraps to avoid going over 80
chars wide whenever possible.  Finishes off bug 197933.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10657
2009-07-29 23:34:49 +00:00
Nicholas Nethercote
78b2e5c83e Started overhauling the documentation:
- There were detailed descriptions of all the tools in the Quick Start
  Guide, the Manual introduction, and the start of each tool chapter.  To
  avoid duplication/overlap, I removed these altogether from the Quick Start
  Guide, and shortened them in the intro.

- Improved the description of what errors Memcheck can find.

- Made all tool chapters start with "Overview" section, for consistency.

- Made the "run with --tool=XXX" bit consistent in each tool chapter.

- Made all tool chapter titles match the description given when running them.

- Added BBV to the User Manual intro.

- Generally clarified, updated, and future-proofed various bits of text in
  the Quick Start Guide and User Manual introduction. 

Also:
- Changed Nulgrind's start-up description to "the minimal Valgrind tool".

- Fixed some punctuation in the usage message.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10652
2009-07-29 02:36:21 +00:00
Tom Hughes
9bab1b80f8 Make sure the x86 direction flag is cleared again if we set it as part
of a test, as the x86 requires it to be clear when any function is called
and gcc 4.3.0 and later rely on that. Fixes #201708.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10642
2009-07-27 23:09:42 +00:00
Nicholas Nethercote
bd7381bd00 mremap2 is a totally unreliable test; it's the only test that fails on a
number of Linux machines.  This change makes it more reliable, at the cost
of being less specific.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10575
2009-07-24 05:38:23 +00:00
Nicholas Nethercote
aa4962d995 In r10465 --time-stamp=yes got slightly broken -- the space between the time
and the PID was removed.  This commit adds it back in.  It also adds a basic
test that would have detected this regression, and also the breakage in bug
200990.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10573
2009-07-24 05:16:31 +00:00
Bart Van Assche
1804bafbd3 Updated expected output.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10522
2009-07-22 17:38:36 +00:00
Bart Van Assche
06d1aa76b3 Fixed the inline assembly code such that it also works correctly with gcc 4.4.0. While accessing stack variables from inline assembly code that modifies the stack pointer works fine with gcc 3.0 - gcc 4.3 with optimization disabled, it gives incorrect results with gcc 4.4.0.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10484
2009-07-18 10:39:14 +00:00
Julian Seward
f54726edbb Merge none/ changes from branches/MESSAGING_TIDYUP r10464.
See trunk r10465 commit message for details.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10475
2009-07-15 14:52:02 +00:00
Nicholas Nethercote
75b92a2ec9 Shorten the preamble by moving some of it into the --help output. This
partly fixes bug 197933.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10451
2009-07-14 06:55:05 +00:00
Nicholas Nethercote
62851019a9 Suppress an error within syslog(). Patch from Dan Kegel. Fixes bug 191192.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10438
2009-07-13 07:02:26 +00:00
Julian Seward
e818cd9481 Only run none/tests/amd64/bug127521-64 on machines supporting cmpxchg16b.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10433
2009-07-12 13:17:18 +00:00
Julian Seward
205f7fa457 Add tests to verify behaviour of atomic instruction handling.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10410
2009-07-04 12:44:08 +00:00
Nicholas Nethercote
07a1251a20 Make the Linux launcher more like the Darwin one in how it reads the
executable headers.  This means it no longer crashes on an empty executable.
Fixes bug 156065.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10384
2009-06-29 06:57:30 +00:00
Nicholas Nethercote
b05a2a18d7 This commit merges the BUILD_TWEAKS branch onto the trunk. It has the
following improvements:

- Arch/OS/platform-specific files are now included/excluded via the
  preprocessor, rather than via the build system.  This is more consistent
  (we use the pre-processor for small arch/OS/platform-specific chunks
  within files) and makes the build system much simpler, as the sources for
  all programs are the same on all platforms.

- Vast amounts of cut+paste Makefile.am code has been factored out.  If a
  new platform is implemented, you need to add 11 extra Makefile.am lines.
  Previously it was over 100 lines.

- Vex has been autotoolised.  Dependency checking now works in Vex (no more
  incomplete builds).  Parallel builds now also work.  --with-vex no longer
  works;  it's little use and a pain to support.  VEX/Makefile is still in
  the Vex repository and gets overwritten at configure-time;  it should
  probably be renamed Makefile-gcc to avoid possible problems, such as
  accidentally committing a generated Makefile.  There's a bunch of hacky
  copying to deal with the fact that autotools don't handle same-named files
  in different directories.  Julian plans to rename the files to avoid this
  problem.

- Various small Makefile.am things have been made more standard automake
  style, eg. the use of pkginclude/pkglib prefixes instead of rolling our
  own.

- The existing five top-level Makefile.am include files have been
  consolidated into three.

- Most Makefile.am files now are structured more clearly, with comment
  headers separating sections, declarations relating to the same things next
  to each other, better spacing and layout, etc.

- Removed the unused exp-ptrcheck/tests/x86 directory.

- Renamed some XML files.

- Factored out some duplicated dSYM handling code.

- Split auxprogs/ into auxprogs/ and mpi/, which allowed the resulting
  Makefile.am files to be much more standard.

- Cleaned up m_coredump by merging a bunch of files that had been
  overzealously separated.

The net result is 630 fewer lines of Makefile.am code, or 897 if you exclude
the added Makefile.vex.am, or 997 once the hacky file copying for Vex is
removed.  And the build system is much simpler.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10364
2009-06-24 00:37:09 +00:00
Nicholas Nethercote
efcb72de6f Unbreak nestedfns on --enable-only32bit installations.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10165
2009-05-29 00:31:31 +00:00
Nicholas Nethercote
64dcb65ca5 Make this file executable too.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10158
2009-05-28 02:24:28 +00:00
Nicholas Nethercote
07045477ca Merge the DARWIN branch onto the trunk.
I tried using 'svn merge' to do the merge but it did a terrible job and
there were bazillions of conflicts.  So instead I just took the diff between
the branch and trunk  at r10155, applied the diff to the trunk, 'svn add'ed
the added files (no files needed to be 'svn remove'd) and committed.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10156
2009-05-28 01:53:07 +00:00
Nicholas Nethercote
8d02058b42 DARWIN sync: Makefile.am layout, mostly.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10016
2009-05-20 04:02:50 +00:00
Nicholas Nethercote
d69e4febc3 DARWIN sync: add a #include.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10013
2009-05-20 03:54:09 +00:00
Nicholas Nethercote
fad023c993 Remove unnecessary #include.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9964
2009-05-19 06:06:14 +00:00
Nicholas Nethercote
86ccf0ca56 Add some missing 'make dist' files.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9907
2009-05-19 00:05:29 +00:00
Nicholas Nethercote
8795795b55 Merge r9900 (make dist fixes) from the MESSAGING_TIDYUP branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9905
2009-05-18 23:24:26 +00:00
Nicholas Nethercote
087255f973 Merge part of r9709 (m_signals.c clean-ups) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9737
2009-05-03 22:53:19 +00:00
Nicholas Nethercote
178bd263af Refactor and recomment async-sigs so it's easier to understand. Send all
its output to stderr as well.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9706
2009-05-01 05:00:34 +00:00
Nicholas Nethercote
af09b2fa03 Fix test breakage caused by r9694.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9697
2009-04-30 05:09:09 +00:00
Nicholas Nethercote
437821f592 Merged r9673 (remove susphello) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9674
2009-04-29 04:18:30 +00:00
Nicholas Nethercote
4a812f8a14 Merge r9667 (fdleak_ipv4 portability tweak) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9669
2009-04-29 02:04:57 +00:00
Nicholas Nethercote
5976184a68 Merge r9666 (badseg portability tweak) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9668
2009-04-29 02:02:19 +00:00
Nicholas Nethercote
fcb90ff490 Merged r9657 (fdleak fixes) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9658
2009-04-28 05:35:53 +00:00
Nicholas Nethercote
32bd1a00c2 Merge r9610 (AM_CCASFLAGS tweaks for test Makefiles) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9611
2009-04-24 20:17:07 +00:00
Nicholas Nethercote
3b383dab10 Merged r9602 and r9603 (make cpuid pass on Darwin, rename .s files to .S)
from the DARWIN branch.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9604
2009-04-24 07:12:39 +00:00
Nicholas Nethercote
e91540cc58 Merged r9596 (build system tweaks, minus the Darwin bits) from the DARWIN
branch.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9598
2009-04-24 04:12:28 +00:00
Nicholas Nethercote
3ee960caa2 Merge r9571 (get faultstatus building again) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9572
2009-04-17 07:14:29 +00:00
Nicholas Nethercote
c0a50d778d Merge r9564 (make pth_cvsimple more reliable) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9565
2009-04-16 02:04:07 +00:00
Nicholas Nethercote
894ec4e1fd Merge r9550..r9552 (move seg_override and sigcontext) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9553
2009-04-15 23:10:04 +00:00
Nicholas Nethercote
13e765c304 Merged r9546..r9548 (moved blockfault, and filtering fixes) from the DARWIN
branch.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9549
2009-04-15 07:11:36 +00:00
Nicholas Nethercote
f3f801ed48 Merge r9533..9536 (add tests/{asm.h,sys_mman.h,malloc.h} from the DARWIN
branch.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9537
2009-04-15 03:12:43 +00:00
Nicholas Nethercote
3588261281 Merge r9456 (pending change) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9457
2009-03-17 06:22:58 +00:00
Nicholas Nethercote
ce14b8f2fa Merge r9429 (map_unaligned porting) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9430
2009-03-16 04:29:12 +00:00
Nicholas Nethercote
272ecb8e5d Merge r9426, r9427 ('pending' portability tweaks) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9428
2009-03-16 03:46:48 +00:00
Nicholas Nethercote
7cfc244df8 Merge r9380, r9381 (test portability tweaks) from the DARWIN branch.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9394
2009-03-13 05:38:01 +00:00
Nicholas Nethercote
44301100b5 Added better filtering for Helgrind tests, removing all unreliable stack
traces, and a few other unreliable pieces.  This allowed most of the tests
to be reduced to a single .stderr.exp file.  It also means that all Helgrind
tests succeed on my AMD64/Linux box when configured with --enable-only32bit,
whereas previously 20 of them failed.

Also tweaked a couple non-Helgrind filters a tiny bit.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@9389
2009-03-13 01:41:03 +00:00