8481 Commits

Author SHA1 Message Date
Bart Van Assche
64a2d66bdf Silence compiler warnings triggered by certain regression tests programs and that we are not interested in.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11758
2011-05-15 17:06:33 +00:00
Bart Van Assche
e04a1bbb64 Added configure tests for the compiler flags -Wno-nonnull and -Wno-overflow.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11757
2011-05-15 17:05:36 +00:00
Bart Van Assche
e9947dd263 Removed "prereq: test -e gdb" again from those tests that do not invoke the script gdbserver_tests/gdb.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11756
2011-05-15 16:45:42 +00:00
Bart Van Assche
9a36fe677e Get rid of the remaining "set but not used" warnings reported by gcc 4.6 by
swapping the roles of the VALGRIND_DO_CLIENT_REQUEST() and
VALGRIND_DO_CLIENT_REQUEST_EXPR() macros. Also, many __attribute__((unused))
declarations on variables have been eliminated. Closes #269778.

Note: so far this patch has been tested on x86/Linux, amd64/Linux and
ppc64/Linux but not yet on any other supported CPU/OS combination.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11755
2011-05-15 07:04:03 +00:00
Bart Van Assche
55962f8342 Updated Subversion ignore list.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11754
2011-05-15 06:41:37 +00:00
Bart Van Assche
bdf797c009 gdbserver tests: only create the gdbserver_tests/gdb soft link if ./configure found gdb.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11753
2011-05-15 06:18:24 +00:00
Bart Van Assche
75f462e649 Skip gdbserver tests if ./configure did not find gdb.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11752
2011-05-15 06:07:57 +00:00
Bart Van Assche
29b06865ca gdbserver_tests/t.c: Fixed two occurrences of the same typo.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11751
2011-05-15 05:44:59 +00:00
Julian Seward
e9392d2bbc Remove old exp-ptrcheck tests which were never used.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11750
2011-05-12 19:15:06 +00:00
Julian Seward
f5fb84ba81 Delete exp-sgcheck tests that are redundant following the removal of the
heap checking facilities.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11749
2011-05-12 16:38:56 +00:00
Julian Seward
619a546991 * fixed two bugs reported by the IBM BEAM checker:
fd leak in vgdb.c
     break missing in valgrind-low-s390x.c

* use option --vgdb=full for the tests mcsigpass.vgtest and mcsignopass.vgtest
  This might improve these tests on ppc32/debian 6.0

* added a paragraph in gdbserver_tests/README_DEVELOPPERS to indicate
  how to report problems about failing gdbserver tests.

(bug 214909 comment 71, Philippe Waroquiers, philippe.waroquiers@skynet.be)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11748
2011-05-11 22:54:57 +00:00
Josef Weidendorfer
8498c6ff81 Fixed bug 272661
Paths should be quoted in regexps (in callgrind_annotate).

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11747
2011-05-11 16:45:52 +00:00
Josef Weidendorfer
0c8d0306ea Fix bug 267383
As suggested by Florian. Cachegrind already does the same.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11746
2011-05-11 16:32:18 +00:00
Julian Seward
b71e8bb6c5 Rename 'exp-ptrcheck' to 'exp-sgcheck' and hope this does not cause
too much build carnage.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11745
2011-05-11 16:04:28 +00:00
Julian Seward
897fd70777 When reading Dwarf3 variable type and location information, print a
line showing the number of variables read for each object.  Currently
disabled -- is a sanity-check mechanism for exp-sgcheck.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11744
2011-05-11 15:31:24 +00:00
Julian Seward
c3617f305a Update the manual following removal of heap-check functionality.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11743
2011-05-11 15:26:06 +00:00
Josef Weidendorfer
1e4d49cc8c Fix bugs catched by BEAM
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11742
2011-05-11 12:28:01 +00:00
Julian Seward
77521499b3 Remove heap checking from exp-ptrcheck, leaving only the ability to
check for overruns of stack and global arrays.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11741
2011-05-11 12:01:37 +00:00
Julian Seward
b37b05d214 Improvements for testing and compilation breakage for the GDB server
on various platforms:

* In all gdbserver_tests using gdb:
  Made a more general way to remove the initial start message.

* tests using threads burning cpu modified to have only 1 thread.
  This makes them independent of the scheduler fairness.

* filter_gdb and filter_vgdb enhanced to anonymise
    some debian 6.0/ppc specific things
    some s390x/gdb 7.0, gdb 7.1  specific things

* vgdb.c: added an #include <linux/ptrace.h> to fix compilation
  on s390x fedora and suse. (Christian Boerntrager)

* fixed a bug in valgrind-low.c debug log :
  when a register size is 0, its image cannot be output (and register
  should not be transferred).

* added a parameter --keep-unfiltered to vg_regtest.in
  This will make it easier to update filter_gdb:
  in case gdbserver_tests are failing due to "artificial"
  differences to be filtered, re-run the tests using:
     perl tests/vg_regtest --keep-unfiltered gdbserver_tests
  Then a tar file with all the *.out in gdbserver_tests
  will allow me to better/faster update the filter_gdb.

* made a better detection of a working PTRACE_GETREGS at compile time
  and/or at run-time.

This is the patch on bug 214909 comment 69.
(Philippe Waroquiers, philippe.waroquiers@skynet.be)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11740
2011-05-10 11:01:07 +00:00
Julian Seward
1930427ceb Handle executables created by the Xcode 3.2.x linker. These contain
LC_DYSYMTAB sections that apparently the 4.0.x created ones don't.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11739
2011-05-10 08:42:14 +00:00
Julian Seward
f8ca357dff Back out r11705, which was an attempt to make reading of line number
info created by LLVM 2.9 work properly.  As per long discussion in
#272189, this isn't actually possible -- LLVM 2.9 creates bogus line
number info, and the bogusness can't be worked around at the Valgrind
end.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11738
2011-05-09 22:51:14 +00:00
Julian Seward
c797d22c85 VG_(mkstemp): fix infinite loop in the case where /tmp isn't
writable.  Fixes #223249.  (Florian Krohm, britzel@acm.org)


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11737
2011-05-09 22:42:06 +00:00
Julian Seward
e22276cef0 Tidying up of branch-predict hint macros LIKELY/UNLIKELY. Fixes
#271504.  (Florian Krohm, britzel@acm.org)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11736
2011-05-09 21:54:44 +00:00
Julian Seward
2146140b60 Fix link flags so that 'vgdb' can be built on x86-darwin.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11735
2011-05-09 21:33:32 +00:00
Bart Van Assche
1a1c896c7b memcheck: Fixed a bug in the address ranges reported in an error message. Closes #272615.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11734
2011-05-09 10:46:55 +00:00
Julian Seward
f83e5835b1 read_dwarf2_lineblock: debug printing fix (no functional change)
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11733
2011-05-09 09:19:32 +00:00
Julian Seward
b113473e03 ppc{32,64}-linux: mark VG_MINIMAL_LONGJMP as noreturn, since it is,
and not doing so leads to compiler warnings for functions that tail
call this one, which themselves are marked "attribute noreturn".


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11732
2011-05-09 09:15:28 +00:00
Bart Van Assche
a24d3fb4cf Updated Subversion ignore list.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11731
2011-05-08 10:10:46 +00:00
Bart Van Assche
0674835647 Follow-up for r11729: make the gdbserver regression tests pass again.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11730
2011-05-08 10:10:04 +00:00
Bart Van Assche
3bea9dc7de Fixed one bug in gdbserver_tests/t.c and several compiler warnings triggered by the gdbserver test programs.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11729
2011-05-08 09:29:06 +00:00
Bart Van Assche
37474bbe01 Added Subversion ignore list for directory gdbserver_tests.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11728
2011-05-08 09:10:33 +00:00
Julian Seward
2ee9e90486 Implement a GDB server in Valgrind. See #214909.
(Philippe Waroquiers, philippe.waroquiers@skynet.be)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11727
2011-05-06 21:02:55 +00:00
Julian Seward
ed9d566463 mkLazyN: fix incorrect type decl for 'mergeTy64', as spotted by IBM's
BEAM checker.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11726
2011-05-04 09:09:31 +00:00
Julian Seward
21dc1d9d42 scalarts_limitations_fail_NORETURN: fix a format string error
spotted by IBM's BEAM checker.  (Why didn't gcc or clang see this?)


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11725
2011-05-04 09:08:34 +00:00
Julian Seward
29c20eaeb0 setup_client_stack: use have_exename to consistently guard uses
of VG_(args_the_exename), thereby avoiding a potential segfault.
Spotted by IBM's BEAM checker.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11724
2011-05-04 09:07:38 +00:00
Julian Seward
1ccdd881a6 calling format_message: when passing frameNo == -1, also pass
tid == VG_INVALID_THREADID rather than an uninitialised ThreadId.
Also in format_message, improve precondition assertions for
frameNo and tid.

There's no error in the current code since if frameNo == -1 then
tid is unused, but it caused IBM's BEAM checker to complain.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11723
2011-05-04 09:06:17 +00:00
Julian Seward
a31f76b8fc handle_maybe_load_notifier: assert when symbol == NULL rather than
segfaulting.  Potential segfault was found by IBM's BEAM checker.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11722
2011-05-04 09:03:41 +00:00
Julian Seward
8911c2ffa5 VG_(env_unsetenv), VG_(env_clone): add assertions so as to cause
assertions instead of segfaults.  Potential segfaults were detected by
IBM's BEAM checker.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11721
2011-05-04 09:01:58 +00:00
Julian Seward
555e3b2ccb arm-linux: Set _start symbol alignment and type. Bug 266035 comment 1.
(Jeff Brown, jeffbrown@google.com)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11720
2011-05-03 14:24:11 +00:00
Bart Van Assche
b9d948061a DRD: fix issues reported by the IBM static analysis tool.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11719
2011-04-30 07:27:41 +00:00
Julian Seward
3b0d8644cb s390x : misc cleanups
- Forgotten cleanups in none/tests/s390x/Makefile.am

Partial fix for #271501.  (Florian Krohm, britzel@acm.org)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11718
2011-04-28 20:14:48 +00:00
Bart Van Assche
fbdd04d5a9 syswrap/Linux: trace ioctl() calls only once / do not report two-argument
ioctl() calls as an error. Patch provided by Mark Hills. Closes #272730.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11717
2011-04-28 18:36:49 +00:00
Julian Seward
5e6d4577de Change the TT_FAST hash function for from "insn_address >> 2" to
"insn_address >> 1".  The former is appropriate for ARM code, where
all insns are 4-sized and 4-aligned, but not for Thumb code, where the
minimum size and alignment is 2.  The old scheme happened to work for
Thumb (indeed, any hash function would), but caused huge amounts of
conflict misses in the fast cache for some programs.

The change has been observed to reduce conflict misses by up to 100
times, and in some cases, improves performance significantly for Thumb
code.  Performance of ARM code is unchanged or possibly a bit worse.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11716
2011-04-28 14:58:15 +00:00
Julian Seward
6045181f3c Change the default (minimum) client malloc alignment from 8 to 16
on ppc32-linux.  This is needed to make Altivec-using code work
correctly.  Noticed when running ./auxprogs/gsl16test with gcc-4.6
with args -mcpu=970 -g -O3 -ftree-vectorize on Memcheck, in
which case a few of the tests failed because malloc() returns
8 byte aligned memory when it should return 16-aligned memory.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11715
2011-04-27 23:25:15 +00:00
Robert Walsh
7671cab5c8 Fix no-arg ioctls on Darwin.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11714
2011-04-27 19:04:31 +00:00
Julian Seward
482237674c s390x: fpr - gpr transfer facility -- valgrind side fixes,
and test cases.  Fixes #268619.
(Florian Krohm, britzel@acm.org)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11713
2011-04-27 12:00:51 +00:00
Julian Seward
62c800bccb Fix bogus asm constraints in jm-insns.c. Fixes #263919.
(Maynard Johnson, maynardj@us.ibm.com)


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11712
2011-04-27 11:33:44 +00:00
Julian Seward
63eda9ca5a Add alternative expected output cases for more recent glibcs (eg,
2.12), which print a minus sign for NaNs.  Fixes #262989.
(Maynard Johnson, maynardj@us.ibm.com)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11711
2011-04-27 11:11:22 +00:00
Julian Seward
3a444148fd Fix a bunch of printf format-string warnings when compiling this "-m64".
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11710
2011-04-27 08:09:37 +00:00
Julian Seward
d1ed036fc5 Fix a type mismatch that gcc-4.6 warns about.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11709
2011-04-26 10:23:54 +00:00