Paul Floyd 5d38764204 Bug 464476 - Firefox fails to start under Valgrind
On FreeBSD, Firefox uses the kern.proc.pathname.PID sysctl
to get the binary path (where PID can be the actual pid
or -1). The user path is /usr/local/bin/firefox which is
a symlink to /usr/local/lib/firefox/firefox.

This was failing because we were not handling this MIB.
That meant that the sysctl returned the path for the
binary of the running tool (e.g.,
/home/paulf/scratch/valgrind/memcheck/memcheck-amd64-freebsd).
Firefox looks for files in the same directory.
Since it was the wrong directory it failed to find them and
exited.

I also noticed a lot of _umtx_op errors. On analysis they
are spurious. The wake ops take an "obj" argument, a pointer
to a variable. They only use the address as a key for
lookups and don't read the contents.
2023-01-21 17:55:09 +01:00

34 lines
759 B
C++

// roughly based on the code for Firefox class BinaryPath
// https://searchfox.org/mozilla-central/source/xpcom/build/BinaryPath.h#185
#include <iostream>
#include <sys/types.h>
#include <sys/sysctl.h>
#include <limits.h>
#include <string>
using std::cerr;
using std::cout;
using std::string;
int main(int argc, char **argv)
{
char aResult[PATH_MAX];
int mib[4];
mib[0] = CTL_KERN;
mib[1] = KERN_PROC;
mib[2] = KERN_PROC_PATHNAME;
mib[3] = -1;
size_t len = PATH_MAX;
if (sysctl(mib, 4, aResult, &len, nullptr, 0) < 0) {
cerr << "sysctl failed\n";
return -1;
}
if (string(aResult) == argv[1]) {
cout << "OK\n";
} else {
cerr << "Not OK aResult " << aResult << " argv[1] " << argv[1] << '\n';
}
}