mirror of
https://github.com/Zenithsiz/ftmemsim-valgrind.git
synced 2026-02-03 10:05:29 +00:00
8eb547054a
For execve valgrind would silently fail when argv was NULL or unadressable. Make sure that this produces a warning under memcheck. The linux kernel accepts argv[0] being NULL, but most other kernels don't since posix says it should be non-NULL and it causes argc to be zero which is unexpected and might cause security issues. This adjusts some testcases so they don't rely on execve succeeding when argv is NULL and expect warnings about argv or argv[0] being NULL or unaddressable. https://bugs.kde.org/show_bug.cgi?id=450437
54 lines
1.5 KiB
C
54 lines
1.5 KiB
C
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
if (argc == 1)
|
|
{
|
|
// This tests the case where argv and envp are NULL, which is easy to
|
|
// get wrong because it's an unusual case. It is also bad and only
|
|
// "worked" by accident with the linux kernel.
|
|
|
|
char *const argv_exe[] = {"true", NULL};
|
|
char *const v_null[] = { NULL };
|
|
char *const v_minus_one[] = { (char *const) -1, NULL };
|
|
|
|
#if defined(VGO_solaris)
|
|
const char *exe = "/bin/true";
|
|
#elif defined(VGO_darwin)
|
|
const char *exe = "/usr/bin/true";
|
|
#elif defined(VGO_freebsd)
|
|
const char *exe = "/usr/bin/true";
|
|
#else
|
|
const char *exe = "/bin/true";
|
|
#endif
|
|
|
|
/* Try some bad argv and envp arguments, make sure the executable
|
|
doesn't actually exists, so execve doesn't accidentally succeeds. */
|
|
if (execve("/%/", NULL, NULL) >= 0)
|
|
printf ("WHAT?");
|
|
if (execve("/%/", (void *)-1, NULL) >= 0)
|
|
printf ("WHAT?");
|
|
if (execve("/%/", v_null, NULL) >= 0)
|
|
printf ("WHAT?");
|
|
if (execve("/%/", v_null, v_null) >= 0)
|
|
printf ("WHAT?");
|
|
if (execve("/%/", v_minus_one, NULL) >= 0)
|
|
printf ("WHAT?");
|
|
if (execve("/%/", v_minus_one, v_null) >= 0)
|
|
printf ("WHAT?");
|
|
if (execve("/%/", v_minus_one, v_minus_one) >= 0)
|
|
printf ("WHAT?");
|
|
|
|
/* Finally a correct execve. */
|
|
if (execve(exe, argv_exe, NULL) < 0)
|
|
{
|
|
perror("execve");
|
|
exit(1);
|
|
}
|
|
}
|
|
|
|
exit(0);
|
|
}
|