Commit Graph

154 Commits

Author SHA1 Message Date
Julian Seward
2fc4ae0c18 - Remove extraneous 'o' (will be stored in svn server for possible
future use)

- Fix tag

- Fix long line which wraps around in html output



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7247
2007-11-28 01:55:29 +00:00
Nicholas Nethercote
347873b9a4 Clarify peak-taking details.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7243
2007-11-27 21:38:14 +00:00
Nicholas Nethercote
3387ddba10 Massif doc fixes, mostly from Julian.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7242
2007-11-27 21:29:33 +00:00
Nicholas Nethercote
44e10a1a18 Minor updates.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7239
2007-11-27 02:03:44 +00:00
Nicholas Nethercote
8905fb6038 This should have gone in with r7233.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7234
2007-11-27 00:59:17 +00:00
Nicholas Nethercote
ab36cf9dde Update test output for a recent graph-drawing change. Update some notes.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7233
2007-11-27 00:53:56 +00:00
Nicholas Nethercote
78e4acd024 Minor tweak to drawing of peak and detailed snapshot bars on the graph.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7231
2007-11-26 22:27:02 +00:00
Nicholas Nethercote
8d6ffee32a Minor tweak to x-axis positioning of bars.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7230
2007-11-26 22:17:19 +00:00
Nicholas Nethercote
01e4f950f2 - Rewrote documentation.
- Added a new time unit, instructions executed, and made it the default -- it's
  much more reproducible and consistent than milliseconds.  Requires IRSB
  instrumentation and so slows down some programs (malloc-light ones such as
  bzip2) by about 20%, others by less.
- ms_print now doesn't overwrite the x-axis in the graphs.
- Added a test for --detailed-freq and --max-snapshots


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7229
2007-11-26 21:59:04 +00:00
Nicholas Nethercote
d6b40a390d Fixed up the log file mess throughout, including the docs. This killed
--log-file-qualifier and --log-file-exactly.

Updated NEWS some in preparation for 3.3.0.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7202
2007-11-23 01:41:32 +00:00
Nicholas Nethercote
4481b0b4be Add support for %q in --massif-out-file. Todo: use this mechanism for the
core and Cachegrind.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7200
2007-11-22 23:01:59 +00:00
Nicholas Nethercote
40dce903a2 Do Massif output file name properly. Default is massif.out.%p, where %p
expands to the PID.  Updated the tests.  Still todo:  handle %q for
environment variables, and do the same for the core and
Cachegrind/Callgrind.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7190
2007-11-20 07:55:40 +00:00
Julian Seward
5e2a8da202 Spelling fixes and misc tidying for the manual. (Brian Gough)
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7173
2007-11-17 09:43:25 +00:00
Nicholas Nethercote
f57a498ccf Another attempt at fixing some Massif regtest failures.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7153
2007-11-12 07:05:07 +00:00
Nicholas Nethercote
982c23d403 Fix verbose output filtering for Massif.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7152
2007-11-12 01:16:24 +00:00
Nicholas Nethercote
b8e2d6e145 - Make other integer CLO macros more correct, as I did for VG_NUM_CLO in the
last commit.
- Add a VG_DBL_CLO for fractional arguments.
- Make Massif's --threshold and --peak-inaccuracy arguments fractional.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7150
2007-11-11 22:15:58 +00:00
Nicholas Nethercote
13c597f709 Add four 'strtoll' variants, which are like 'atoll' but let you detect if
the string converted wasn't entirely numeric.  Using them for numeric
command-line options -- previously if you had a option "--foo=<n>", where
<n> is supposed to be an integer, then "--foo=blah" would be interpreted as
"--foo=0", because the "blah" would be converted to zero and the remaining
chars wouldn't be noticed.

Fixed an incorrect command-line option in two massif tests that this change
exposed.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7149
2007-11-11 21:58:21 +00:00
Nicholas Nethercote
3aacee8b1b Filter out some of Massif's verbose output that varies from machine to
machine, caused by them getting slightly different stack traces.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7134
2007-11-10 04:18:39 +00:00
Nicholas Nethercote
d95559802b Changed Massif to record the 'slop' heap bytes caused by rounding asked-for
sizes up to a multiple of 8 (or whatever --alignment is).  This is combined
with the "admin" bytes, resulting in the "extra" bytes.  Added
VG_(malloc_usable_size) to the tool interface to support this.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7133
2007-11-10 04:08:08 +00:00
Julian Seward
edccec4447 Stop xsltproc barfing on un-escaped '&'.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7129
2007-11-09 23:59:14 +00:00
Julian Seward
75fd9878c9 Merge (from branches/THRCHECK) the following amd64-linux stack unwind
kludges^H^H^H^H^H^H^Henhancements:

r6802: For VG_(record_ExeContext) et al, add a new parameter
(first_ip_delta) which is added to the initial IP value before the
stack is unwound.  A safe value to pass is zero, which causes the
existing behaviour to be unchanged.  This is a kludge needed to work
around the incomplete amd64 stack unwind info in glibc-2.5's clone()
routine.

r7059: Add a last-ditch heuristic-hack to the amd64-linux stack
unwinder, which is used when all other methods fail.  Seems like GDB
has something similar.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7118
2007-11-09 23:02:28 +00:00
Julian Seward
daa5ec20ec Fix tag.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7115
2007-11-09 21:07:31 +00:00
Julian Seward
3432ccbf8b Fix gcc-2.96 build failures.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7085
2007-11-03 11:16:31 +00:00
Nicholas Nethercote
d8769612a2 Update todo notes
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7084
2007-11-02 21:44:02 +00:00
Nicholas Nethercote
ad2b342f32 Fix a Makefile issue that I think caused automated testing to fail on
'alvis' last night.  I don't no why it worked on the other machines, must be
an automake version thing.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7083
2007-11-02 20:47:53 +00:00
Nicholas Nethercote
8a965314f5 Change ms_print to ms_print.in, link it into the build/install system.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7082
2007-11-02 20:44:57 +00:00
Nicholas Nethercote
0a9d806a56 Filter out libc differences. All Massif tests now pass on the AMD64 machine
I just tested.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7081
2007-11-02 04:17:28 +00:00
Nicholas Nethercote
6069e5a71d Fix 64-bit Massif breakage, caused by problems with integer arithmetic on
values of different signs and sizes that only a C language lawyer would
spot.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7080
2007-11-02 04:12:48 +00:00
Nicholas Nethercote
62eed24c67 Merged the MASSIF2 branch to the trunk. Main changes:
- ms_main.c: completely overhauled.

- massif/tests/*:  lots of them now.

- massif/perf/:  added.

- massif/hp2ps:  removed.  No longer used.

- vg_regtest: renamed the previously unused "posttest" notion to "post".
  Using it for checking ms_print's output.

Although the code has changed dramatically, as has the form of the tool's
output, the information presented in the output is basically the same,
although it's now (hopefully) much more useful.  So the tool name is
unchanged.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7069
2007-11-01 04:40:37 +00:00
Dirk Mueller
f5610e96a2 fix various format string errors
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6907
2007-09-24 13:23:53 +00:00
Nicholas Nethercote
7cb817e078 Fix various format string errors, courtesy of Florian Krohm.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6902
2007-09-23 00:51:24 +00:00
Dirk Mueller
377ded5fcb fix division by zero's
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6830
2007-09-14 09:02:25 +00:00
Julian Seward
d838f7b499 Move a 'break' around.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6789
2007-08-28 21:48:09 +00:00
Nicholas Nethercote
6706c608c8 fixed a couple of minor things
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6785
2007-08-27 22:18:58 +00:00
Julian Seward
0e70d01bdd Changes to m_hashtable:
Allow hashtables to dynamically resize (patch from Christoph
Bartoschek).  Results in the following interface changes:

* HT_construct: no need to supply an initial table size.
  Instead, supply a text string used to "name" the table, so
  that debugging messages ("resizing the table") can say which
  one they are resizing.

* Remove VG_(HT_get_node).  This exposes the chain structure to 
  callers (via the next_ptr parameter), which is a problem since
  callers could get some info about the chain structure which then
  changes when the table is resized.  Fortunately is not used.

* Remove VG_(HT_first_match) and VG_(HT_apply_to_all_nodes) as
  they are unused.

* Make the iteration mechanism more paranoid, so any adding or
  deleting of nodes part way through an iteration causes VG_(HT_next)
  to assert.

* Fix the comment on VG_(HT_to_array) so it no longer speaks 
  specifically about MC's leak detector.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6778
2007-08-25 07:19:08 +00:00
Julian Seward
32a6fb4fec Get rid of VG_(getcwd) and replace it with a pair of functions,
VG_(record_startup_wd) which records the working directory at startup,
and VG_(get_startup_wd) which later tells you what value was recorded.
This works because all uses of VG_(getcwd) serve only to record the
directory at process start anyway.  The motivation is that AIX does
not support sys_getcwd directly, so it's easier for the launcher to
ship in the required value using an environment variable.  On Linux
sys_getcwd is used as before.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6764
2007-07-09 23:13:07 +00:00
Julian Seward
b91b51b42b Merge (from 3.2 branch) r6743 (Edit the manual to bring it up to date
and make some of the wording a bit more professional sounding.)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6745
2007-05-23 21:58:33 +00:00
Nicholas Nethercote
802b418634 Fix some copyright notices:
- extend some to 2007
- use njn@valgrind.org instead of njn25@cam.ac.uk
- use "tool" instead of "skin"


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6703
2007-04-15 22:15:57 +00:00
Nicholas Nethercote
904b84c436 Fix bug 142491: allow more --alloc-fn functions (128, up from 32).
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6671
2007-03-26 23:51:29 +00:00
Julian Seward
b7302d9258 Get rid of the type XArrayStrings in m_clientstate and use new generic
equivalents in module m_xarray instead.  A suprisingly pervasive
change.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6616
2007-02-25 15:08:24 +00:00
Julian Seward
172505c978 Update copyright dates.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6488
2007-01-08 06:01:59 +00:00
Julian Seward
1083ded7e2 Non-functional commit: track IR renaming in vex r1689.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6416
2006-12-24 02:24:11 +00:00
Julian Seward
12ef34f623 Track SysRes change.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6294
2006-10-17 02:15:17 +00:00
Julian Seward
713b2d46c0 Merge r6086:
Makefile.am changes for AIX5.  Almost all boilerplate stuff fitting in
with the existing factorisation scheme.  The only change of interest
is that configure.in now generates automake symbols of name
VGP_platform and VGO_os, whereas previously it just made VG_platform
which was a bit inconsistent with the VGP/VGO/VGA scheme used in C
code.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6242
2006-10-17 00:56:43 +00:00
Julian Seward
f4560d1332 Move functions which deal with bad command line options from m_main
into m_options.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6233
2006-10-15 01:25:13 +00:00
Julian Seward
ae8215b3ac Create a new module, m_vki, and move all knowledge about the kernel
interface, except for the syscall numbers, into that.  Mostly this
means moving include/vki-*.h to include/vki/vki-*.h.

include/pub_tool_basics.h previously dragged in the entire kernel
interface.  I've done away with that, so that modules which need to
see the kernel interface now have to include pub_{core,tool}_vki.h
explicitly.  This is why there are many modified .c files -- they have
all acquired an extra #include line.

This certainly breaks all platforms except x86.  Will fix shortly.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@6225
2006-10-14 19:26:10 +00:00
Julian Seward
ad67fd79fe Update copyright dates.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@5954
2006-06-05 23:21:15 +00:00
Julian Seward
afe2b7671f Get rid of compiler warnings.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@5580
2006-01-22 01:09:37 +00:00
Julian Seward
f0d678baab These files all speak about instrumentation functions.
Instrumentation functions now take a callback closure structure
(VgCallbackClosure*), so this commit changes the signatures
accordingly.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@5535
2006-01-17 02:06:39 +00:00
Julian Seward
32f134b8c1 Somewhat rehash the biarch-build machinery so as to (1) formalise the
distinction between primary and secondary build targets, and (2) make
it independent of the default behaviour of gcc (iow, what gcc does
when you specify neither -m32 nor -m64).

As a result, an out-of-the-box build on ppc64-linux now builds a
system which is basically for 64-bit PowerPC, but also has the ability
to run 32-bit ppc-linux binaries (exactly the same arrangement as you
get when building on amd64-linux).

There are various twists and turns.  multiple-architectures.txt is
updated all the gory details.

This will break amd64 builds until such time as
<tool>/tests/{amd64,x86}/Makefile.am are fixed up (shortly).



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@5493
2006-01-04 01:20:28 +00:00