883 Commits

Author SHA1 Message Date
Florian Krohm
4cb2cb656c Fix some grammatical weirness which was reported in BZ #340430.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14670
2014-10-28 16:25:23 +00:00
Julian Seward
8b63b9e588 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14627
2014-10-14 20:26:45 +00:00
Julian Seward
248498908e Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14620
2014-10-11 15:47:12 +00:00
Julian Seward
81fb4ba387 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14592
2014-09-30 12:48:02 +00:00
Philippe Waroquiers
3453b54f22 Add missing ]] to terminate CDATA. Missing brackets are causing
the man page to contain:
               ></programlisting>

                     <para>And here are the same errors with
                     <option>--read-var-info=yes</option>:</para>

               <programlisting><![CDATA[

Rather than the nicely formatted 'And here ...' paragraph.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14561
2014-09-22 19:19:50 +00:00
Julian Seward
f34e93c07d Record some bugs outstanding following 3.10.0.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14523
2014-09-12 09:47:00 +00:00
Julian Seward
3de0c7c918 Merge r14514 from 3_10_BRANCH (--> 3.10.0)
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14521
2014-09-12 09:27:35 +00:00
Julian Seward
44591524a2 Merge r14513 from 3_10_BRANCH (Update docs w.r.t. status of
partially-enabled --read-inline-info.)



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14520
2014-09-12 09:22:36 +00:00
Julian Seward
d05ae2a6a9 Create 3_10_BUGSTATUS.txt.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14496
2014-09-08 11:22:52 +00:00
Julian Seward
af4f057184 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14495
2014-09-08 11:21:10 +00:00
Julian Seward
de3c2f793b Rename "--kernel-variant=android-emulator-no-hw-tls" to
"=android-no-hw-tls" per suggestion from Philippe.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14479
2014-09-06 14:45:12 +00:00
Julian Seward
26f0bb05e7 Be more careful to separate build flags for the preload shared objects
as opposed to the valgrind code proper.  In particular, make sure that
-mpreferred-stack-boundary=2 does not get used for the preload shared
objects, since that can cause the stack to become misaligned and leads
to segfaults.  Modified version of a patch from Matthias Schwarzott
(zzam@gentoo.org).  Fixes #324050.

Also, fix the configure check in configure.ac for
-mpreferred-stack-boundary=2 so that it checks whether this is
allowable for 32-bit code generation even on 64-bit (x86) hosts.  This
check was wrong before now and led to 32-bit builds on 64-bit hosts
generating poorer code for speed critical helper functions (eg
helperc_LOADV32le) than on 32-bit builds on 32-bit hosts.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14471
2014-09-05 20:00:22 +00:00
Florian Krohm
02e0bd5aa0 Revert an accidentally checked in change.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14460
2014-09-04 18:37:56 +00:00
Florian Krohm
b0353a1486 Add a few more tasks to consider.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14459
2014-09-04 18:37:02 +00:00
Julian Seward
7710bd5318 Remove accidentally committed bit of text.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14450
2014-09-04 10:15:52 +00:00
Julian Seward
39b8117fc8 Document the new --kernel-variant options committed in r14440.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14448
2014-09-03 22:21:25 +00:00
Florian Krohm
a2ecdcb67c Add a redirection for the 'index' function.
Fixes BZ #327943


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14441
2014-09-03 16:01:10 +00:00
Julian Seward
f5b14667aa Update after more triaging.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14439
2014-09-03 07:25:06 +00:00
Florian Krohm
be54c05513 Deprecate --db-attach Fixes BZ #337871
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14401
2014-09-01 06:37:07 +00:00
Julian Seward
917e8e40f8 Initial triage pass for all remaining newly opened bugs.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14395
2014-08-30 10:09:30 +00:00
Julian Seward
fd1166d11d arm64: record the use of x8 as of vex r2938.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14389
2014-08-29 22:02:56 +00:00
Julian Seward
db85fec898 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14387
2014-08-29 19:34:45 +00:00
Philippe Waroquiers
8e605f14c5 Add option a new sim-hint no-nptl-pthread-stackcache.
Activating this hint using --sim-hints=no-nptl-pthread-stackcache
means the glibc nptl stack cache will be disabled.

Disabling this stack/tls cache avoids helgrind false positive race conditions
errors when using __thread variables.

Note: disabling the stack cache is done by a kludge, dependent on
internal knowledge of glibc code, and using libpthread debug info.
So, this kludge might be broken with newer glibc version.
This has been tested on various platforms and various
glibc versions 2.11, 2.16 and 2.18

To check if the disabling works, you can do:
valgrind --tool=helgrind --sim-hints=no-nptl-pthread-stackcache -d -v ./helgrind/tests/tls_threads |& grep kludge

If you see the below 2 lines, then hopefully the stack cache has been disabled.
--12624-- deactivate nptl pthread stackcache via kludge: found symbol stack_cache_actsize at addr 0x3AF178
--12624:1:sched    pthread stack cache size disabling done via kludge




git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14313
2014-08-19 22:46:44 +00:00
Florian Krohm
d31fe530ff Fix a typo.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14312
2014-08-19 16:53:02 +00:00
Tom Hughes
ea9b0ccd7d Document fix of BZ#315199.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14182
2014-07-23 07:54:41 +00:00
Philippe Waroquiers
2a49250682 Small fixes in 'getting started' section of user manual
* Mention --read-inline-info=yes as an alternative to compile without inlining.

* Mention that stabs debuginfo reader is not working anymore since 3.9.0



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14160
2014-07-14 22:04:17 +00:00
Tom Hughes
94b049ff1d Add support for various SIOCETHTOOL operations. BZ#303536.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14114
2014-06-27 09:59:52 +00:00
Tom Hughes
49ed137491 Wire up recvmmsg on arm. BZ#334585.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14113
2014-06-26 13:34:53 +00:00
Tom Hughes
13c65e031d Add SIOCATMARK ioctl support.
Patch from Austin English via BZ#335441.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14112
2014-06-26 13:14:56 +00:00
Tom Hughes
4ef60ef102 Implement various SNDRV_CTL_xxx ioctls.
Patch from Ivan Sorokin via BZ#334936.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14111
2014-06-26 12:53:23 +00:00
Tom Hughes
e97f8c49d6 Handle the HCIGETDEVLIST ioctl.
Based on patch from Tomasz Nowak via BZ#335034.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14109
2014-06-26 11:44:46 +00:00
Tom Hughes
5f4dbbeb75 Add support for the SG_IO ioctl.
Patch from Daniel Kamil Kozar via BZ#333817.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14107
2014-06-26 11:29:05 +00:00
Tom Hughes
ba3d08c7a7 Handle the CDROM_DISC_STATUS ioctl.
Patch from Daniel Kamil Kozar via BZ#333788.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14106
2014-06-26 11:11:56 +00:00
Tom Hughes
d2201dd27f Remove bug closed by reporter
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14105
2014-06-26 11:07:42 +00:00
Tom Hughes
8c9c829f4c Add support for TIOCNOTTY ioctl. BZ#331476.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14104
2014-06-26 11:03:32 +00:00
Florian Krohm
a4923d3057 Suppress a clang warning about an uninitialised variable.
Fixes BZ #329694.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14092
2014-06-24 11:35:45 +00:00
Bart Van Assche
9214c37d49 Rename --defaultsupp into --default-suppressions as requested by Julian
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14090
2014-06-24 05:08:21 +00:00
Florian Krohm
8f46d5fb35 BZ 330257 has been fixed in r14055.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14088
2014-06-23 19:43:32 +00:00
Bart Van Assche
4b6bd7b0fc core: Add command-line option --defaultsupp
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14080
2014-06-22 10:11:59 +00:00
Florian Krohm
31caca50d5 ms_print ought to create temporary files in a proper directory as
specified with --with-tmpdir at configuration time or with TMPDIR
at runtime. Doing so fixes the symptom reported in BZ #332765.
Also fix an incorrect error message.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14077
2014-06-21 20:25:30 +00:00
Philippe Waroquiers
ceaa5b2efe This patch implements the support needed for stacktraces
showing inlined function calls.
See 278972 valgrind stacktraces and suppression do not handle inlined function call debuginfo

Reading the inlined dwarf call info is activated using the new clo
  --read-inline-info=yes
Default is currently no but an objective is to optimise the performance
and memory in order to possibly set it on by default.
(see below discussion about performances).

Basically, the patch provides the following pieces:
1. Implement a new dwarf3 reader that reads the inlined call info
2. Some performance improvements done for this new parser, and
   on some common code between the new parser and the var info parser.
3. Use the parsed inlined info to produce stacktrace showing inlined calls
4. Use the parsed inlined info in the suppression matching and suppression generation
5. and of course, some reg tests

1. new dwarf3 reader:
---------------------
Two options were possible: add the reading of the inlined info
in the current var info dwarf reader, or add a 2nd reader.
The 2nd approach was preferred, for the following reasons:
The var info reader is slow, memory hungry and quite complex.
Having a separate parsing phase for the inlined information
is simpler/faster when just reading the inlined info.
Possibly, a single parser would be faster when using both
--read-var-info=yes and --read-inline-info=yes.
However, var-info being extremely memory/cpu hungry, it is unlikely
to be used often, and having a separate parsing for inlined info
does in any case make not much difference.
(--read-var-info=yes is also now less interesting thanks to commit
r13991, which provides a fast and low memory "reasonable" location
for an address).

The inlined info parser reads the dwarf info to make calls
to priv_storage.h ML_(addInlInfo).

2. performance optimisations
----------------------------
* the abbrev cache has been improved in revision r14035.
* The new parser skips the non interesting DIEs
  (the var-info parser has no logic to skip uninteresting DIEs).
* Some other minor perf optimisation here and there.
In total now, on a big executable, 15 seconds CPU are needed to
create the inlined info (on my slow x86 pentium).

With regards to memory, the dinfo arena:
with inlined info: 172281856/121085952  max/curr mmap'd
without          : 157892608/106721280  max/curr mmap'd,
So, basically, inlined information costs about 15Mb of memory for
my big executable (compared to first version of the patch, this is
already using less memory, thanks to the strpool deduppoolalloc.
The needed memory can probably be decreased somewhat more.

3. produce better stack traces
------------------------------
VG_(describe_IP) has a new argument InlIPCursor *iipc which allows
to describe inlined function calls by doing repetitive calls 
to describe_IP. See pub_tool_debuginfo.h for a description.

4. suppression generation and matching
--------------------------------------
* suppression generation now also uses an InlIPCursor *iipc
  to generate a line for each inlined fn call.

* suppression matching: to allow suppression matching to
match one IP to several function calls in a suppression entry,
the 'inputCompleter' object (that allows to lazily generate
function or object names for a stacktrace when matching 
an error with a suppression) has been generalised a little bit
more to also lazily generate the input sequence.
VG_(generic_match) has been updated so as to be more generic
with respect to the input completer : when providing an
input completer, VG_(generic_match) does not need anymore
to produce/compute any input itself : this is all delegated
to the input completer.

5. various regtests
-------------------
to test stack traces with inlined calls, and suppressions
of (some of) these errors using inlined fn calls matching.


Work still to do:
-----------------
* improve parsing performance
* improve the memory overhead.
* handling the directory name for files of the inlined function calls is not yet done.
  (probably implies to refactor some code)
* see if m_errormgr.c *offsets arrays cannot be managed via xarray



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14036
2014-06-15 15:42:20 +00:00
Julian Seward
e32c76a6c2 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14020
2014-06-10 12:05:33 +00:00
Dejan Jevtic
f1b4547420 mips64: Tests for Cavium MIPS Octeon Atomic and Count Instructions.
Tests for instructions:
baddu, pop, dpop, saa, saad, laa, laad, lai, laid, lad, ladd, law, lawd,
las, lasd, lac, lacd


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13994
2014-06-04 11:36:21 +00:00
Julian Seward
3c4d0c9ee7 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13992
2014-06-01 17:46:18 +00:00
Julian Seward
32adfb9026 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13989
2014-05-21 20:23:43 +00:00
Philippe Waroquiers
ab71852280 Fix 334788 clarify doc about --log-file initial program directory
Behaviour is kept unchanged, a paragraph is added in the doc to
clarify.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13979
2014-05-17 05:50:46 +00:00
Julian Seward
b0e2fd66e4 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13973
2014-05-16 12:22:50 +00:00
Philippe Waroquiers
183b978d08 Factorises the address code description and printing
of memcheck and helgrind in a common module:
  pub_tool_addrinfo.h pub_core_addrinfo.h m_addrinfo.c

At the same time, the factorised code is made usable by other
tools also (and is used by the gdbserver command 'v.info location'
which replaces the helgrind 'describe addr' introduced 1 week ago
and which is now callable by all tools).

The new address description code can describe more addresses
(e.g. for memcheck, if the block is not on the free list anymore,
but is in an arena free list, this will also be described).

Similarly, helgrind address description can now describe more addresses
when --read-var-info=no is given (e.g. global symbols are
described, or addresses on the stack are described as
being on the stack, freed blocks in the arena free list are
described, ...).
See e.g. the change in helgrind/tests/annotate_rwlock.stderr.exp
or locked_vs_unlocked2.stderr.exp

The patch touches many files, but is basically a lot of improvements
in helgrind output files.
The code changes are mostly refactorisation of existing code.




git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13965
2014-05-14 20:39:27 +00:00
Julian Seward
cdce5974bf Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13964
2014-05-14 13:29:04 +00:00
Julian Seward
c4d3b61787 Update.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13954
2014-05-13 09:28:19 +00:00