Revert configure support for adding -Werror=format-security.

This reverts part of valgrind svn r13962. There was a typo in the configure
check that caused failures when -Werror=format-security wasn't supported
and the flag interfered badly with -Wno-format-zero-length. So remove
for now and only add back when properly tested on various (older) setups.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13976
This commit is contained in:
Mark Wielaard 2014-05-16 22:28:48 +00:00
parent 1418e68e22
commit f826a8f60c
2 changed files with 0 additions and 29 deletions

View File

@ -32,10 +32,6 @@ if HAS_WRITE_STRINGS_WARNING
CFLAGS += -Wno-write-strings
endif
if HAS_ERROR_FORMAT_SECURITY
CFLAGS += -Wformat -Werror=format-security
endif
if COMPILER_IS_CLANG
CFLAGS += -Wno-format-extra-args # perf/tinycc.c
CFLAGS += -Wno-literal-range # none/tests/amd64/fxtract.c

View File

@ -1681,31 +1681,6 @@ fi
AM_CONDITIONAL(HAS_WRITE_STRINGS_WARNING, test x$no_write_strings = xyes)
# does this compiler support -Wformat -Werror=format-security ?
AC_MSG_CHECKING([if gcc accepts -Wformat -Werror=format-security])
safe_CFLAGS=$CFLAGS
CFLAGS="-Wformat -Werror=format-security"
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[
return 0;
]])], [
error_format_security=yes
AC_MSG_RESULT([yes])
], [
error_format_security=no
AC_MSG_RESULT([no])
])
CFLAGS=$safe_CFLAGS
if test x$no_write_strings = xyes; then
CFLAGS="$CFLAGS -Wformat -Werror=format-security"
CXXFLAGS="$CXXFLAGS -Wformat -Werror=format-security"
fi
AM_CONDITIONAL(HAS_ERROR_FORMAT_SECURITY, test x$error_format_security = xyes)
# does this compiler support -Wno-empty-body ?
AC_MSG_CHECKING([if gcc accepts -Wno-empty-body])