Remove the Segment back-pointer from SegInfo. The only place it was

being used was in resolve_redir(), and due to the way resolve_redir()
is called, the involved test was always failing anyway.  So we lose
nothing by removing it except some complexity -- there is no longer a
circularity between Segments and SegInfos.







git-svn-id: svn://svn.valgrind.org/valgrind/trunk@4019
This commit is contained in:
Nicholas Nethercote 2005-06-25 19:33:50 +00:00
parent e6094b5400
commit b6a7de7795
3 changed files with 0 additions and 8 deletions

View File

@ -171,7 +171,6 @@ extern void ML_(ppCfiSI) ( CfiSI* );
struct _SegInfo {
struct _SegInfo* next; /* list of SegInfos */
Segment *seg; /* first segment we're mapped out of */
Int ref;
/* Description of the mapped segment. */

View File

@ -1648,8 +1648,6 @@ SegInfo *VG_(read_seg_symbols) ( Segment *seg )
si->cfisi_size = si->cfisi_used = 0;
si->cfisi_minaddr = si->cfisi_maxaddr = 0;
si->seg = seg;
si->stab_typetab = NULL;
si->plt_start = si->plt_size = 0;

View File

@ -210,11 +210,6 @@ static Bool resolve_redir(CodeRedirect *redir, const SegInfo *si)
Bool resolved;
vg_assert(si != NULL);
vg_assert(si->seg != NULL);
/* no redirection from Valgrind segments */
if (si->seg->flags & SF_VALGRIND)
return False;
resolved = from_resolved(redir);
vg_assert(!resolved);