Document that VG_(newSWA) never returns NULL (because its

allocation function does not). Audit call sites.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14533

helgrind/libhb_core.c

@@ -4429,7 +4429,6 @@ static void event_map_init ( void )
                    "libhb.event_map_init.4 (oldref tree)", 
                    HG_(free)
                 );
-   tl_assert(oldrefTree);
 
    oldrefGen = 0;
    oldrefGenIncAt = 0;

include/pub_tool_sparsewa.h

@@ -50,7 +50,8 @@
 
 typedef  struct _SparseWA  SparseWA; /* opaque */
 
-// Create a new one, using the specified allocator/deallocator
+// Create a new one, using the specified allocator/deallocator.
+// Never returns NULL.
 SparseWA* VG_(newSWA) ( void*(*alloc_nofail)(const HChar* cc, SizeT), 
                         const HChar* cc,
                         void(*dealloc)(void*) );