From 1d0d9898a3f71b9335fe23251ba1642edc607a38 Mon Sep 17 00:00:00 2001 From: Filipe Rodrigues Date: Mon, 11 Mar 2024 00:30:02 +0000 Subject: [PATCH] Added warning for lint `clippy::semicolon_if_nothing_returned`. --- Cargo.toml | 1 + dynatos-context/src/lib.rs | 12 ++++++------ dynatos-html/src/lib.rs | 2 +- dynatos-reactive/src/derived.rs | 4 ++-- dynatos-reactive/src/effect.rs | 4 ++-- dynatos-reactive/tests/unsized.rs | 2 +- dynatos-router/src/query_array_signal.rs | 4 ++-- dynatos-router/src/query_signal.rs | 2 +- dynatos/src/element_dyn_attr.rs | 2 +- 9 files changed, 17 insertions(+), 16 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 1d91655..52d8ce6 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -51,3 +51,4 @@ web-sys = "0.3.68" clippy.map_unwrap_or = "warn" clippy.flat_map_option = "warn" clippy.must_use_candidate = "warn" +clippy.semicolon_if_nothing_returned = "warn" diff --git a/dynatos-context/src/lib.rs b/dynatos-context/src/lib.rs index 3eff10e..e3dce3f 100644 --- a/dynatos-context/src/lib.rs +++ b/dynatos-context/src/lib.rs @@ -427,7 +427,7 @@ mod test { let value = VALUE; test::black_box(value); } - }) + }); } #[bench] @@ -439,7 +439,7 @@ mod test { let value = crate::get::(); test::black_box(value); } - }) + }); } #[bench] @@ -451,7 +451,7 @@ mod test { let value = crate::expect::(); test::black_box(value); } - }) + }); } #[bench] @@ -462,7 +462,7 @@ mod test { for _ in 0..test::black_box(REPEAT_COUNT) { crate::with::(|value| test::black_box(value.copied())); } - }) + }); } #[bench] @@ -473,7 +473,7 @@ mod test { for _ in 0..test::black_box(REPEAT_COUNT) { crate::with_expect::(|value| test::black_box(*value)); } - }) + }); } /// Creates several types and attempts to access them all. @@ -498,6 +498,6 @@ mod test { bencher.iter(|| { use_ty! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17, T18, T19, T20, T21, T22, T23, T24, T25, T26, T27, T28, T29, T30, T31, T32, T33, T34, T35, T36, T37, T38, T39, T40, T41, T42, T43, T44, T45, T46, T47, T48, T49 } - }) + }); } } diff --git a/dynatos-html/src/lib.rs b/dynatos-html/src/lib.rs index 400cf40..0be3bc7 100644 --- a/dynatos-html/src/lib.rs +++ b/dynatos-html/src/lib.rs @@ -219,7 +219,7 @@ where .chain(classes.iter().map(C::as_ref)) .join(" "); - self.as_ref().set_class_name(&class_name) + self.as_ref().set_class_name(&class_name); } } diff --git a/dynatos-reactive/src/derived.rs b/dynatos-reactive/src/derived.rs index 2903bbe..5dab8ef 100644 --- a/dynatos-reactive/src/derived.rs +++ b/dynatos-reactive/src/derived.rs @@ -133,7 +133,7 @@ where type Output = (); extern "rust-call" fn call_once(mut self, args: ()) -> Self::Output { - self.call_mut(args) + self.call_mut(args); } } impl FnMut<()> for EffectFn @@ -142,7 +142,7 @@ where F: Fn() -> T, { extern "rust-call" fn call_mut(&mut self, args: ()) -> Self::Output { - self.call(args) + self.call(args); } } impl Fn<()> for EffectFn diff --git a/dynatos-reactive/src/effect.rs b/dynatos-reactive/src/effect.rs index 660311a..83decf7 100644 --- a/dynatos-reactive/src/effect.rs +++ b/dynatos-reactive/src/effect.rs @@ -354,7 +354,7 @@ mod test { let effect = effect::running(); test::black_box(effect); } - }) + }); }); } @@ -366,6 +366,6 @@ mod test { test::black_box(&effect); mem::forget(effect); } - }) + }); } } diff --git a/dynatos-reactive/tests/unsized.rs b/dynatos-reactive/tests/unsized.rs index 3f5bfa4..d0fbd62 100644 --- a/dynatos-reactive/tests/unsized.rs +++ b/dynatos-reactive/tests/unsized.rs @@ -13,6 +13,6 @@ fn create_unsized() { sig.with(|dyn_value| { assert_eq!(dyn_value.type_id(), value.type_id()); - assert_eq!(dyn_value.downcast_ref::(), Some(&value)) + assert_eq!(dyn_value.downcast_ref::(), Some(&value)); }); } diff --git a/dynatos-router/src/query_array_signal.rs b/dynatos-router/src/query_array_signal.rs index f6983ab..a98f285 100644 --- a/dynatos-router/src/query_array_signal.rs +++ b/dynatos-router/src/query_array_signal.rs @@ -178,8 +178,8 @@ where queries.push(((*self.signal.key).to_owned(), value)); } location.query_pairs_mut().clear().extend_pairs(queries); - }) - }) + }); + }); } } diff --git a/dynatos-router/src/query_signal.rs b/dynatos-router/src/query_signal.rs index b9b2ab6..ccab608 100644 --- a/dynatos-router/src/query_signal.rs +++ b/dynatos-router/src/query_signal.rs @@ -176,7 +176,7 @@ where }; location.query_pairs_mut().clear().extend_pairs(queries); - }) + }); }); } } diff --git a/dynatos/src/element_dyn_attr.rs b/dynatos/src/element_dyn_attr.rs index a1d7acb..7daafca 100644 --- a/dynatos/src/element_dyn_attr.rs +++ b/dynatos/src/element_dyn_attr.rs @@ -35,7 +35,7 @@ pub impl web_sys::Element { None => element .remove_attribute(key) .unwrap_or_else(|err| panic!("Unable to remove attribute {key:?}: {err:?}")), - }) + }); }) .or_return()?;